[Backport] Add metadata title in unit test#16631
Closed
ronak2ram wants to merge 1 commit intomagento:2.1-developfrom
ronak2ram:2.1-develop-PR-port-16333
Closed
[Backport] Add metadata title in unit test#16631ronak2ram wants to merge 1 commit intomagento:2.1-developfrom ronak2ram:2.1-develop-PR-port-16333
ronak2ram wants to merge 1 commit intomagento:2.1-developfrom
ronak2ram:2.1-develop-PR-port-16333
Conversation
orlangur
requested changes
Jul 9, 2018
Contributor
orlangur
left a comment
orlangur
left a comment
There was a problem hiding this comment.
@ronak2ram you cannot backport test without backporting an actual fix. Please add corresponding commits into this PR.
Contributor
|
@ronak2ram , I am closing this PR now due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16333
Description
Trying to backport #11368 i've found that @phoenix128 fixed the same issue in 1413d65
This pull request only add test coverage to metadata title
Fixed Issues (if relevant)
Contribution checklist